Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mimir add compactor dir #117

Merged
merged 13 commits into from
Jul 29, 2024
Merged

feat: mimir add compactor dir #117

merged 13 commits into from
Jul 29, 2024

Conversation

saidsef
Copy link
Owner

@saidsef saidsef commented Jul 28, 2024

No description provided.

@saidsef saidsef self-assigned this Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 28, 2024
@saidsef
Copy link
Owner Author

saidsef commented Jul 28, 2024

/code pr

Copy link
Owner Author

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Summary of Suggestions and Issues

deployment/mimir/statefulset.yml

  1. Enhancement Suggestions:

    • Consider adding comments to explain the purpose of new arguments for better maintainability. For example:
      - '-compactor.cleanup-interval=1h'  # Interval for compactor cleanup
    • Ensure that the resource limits and requests are appropriate for your deployment environment. If you anticipate higher loads, you might want to increase the memory and CPU requests/limits further.
  2. Code Consistency:

    • The -log.level argument is set to warn in the last patch. Ensure that this level is appropriate for your logging needs. If debugging is required, consider setting it back to debug temporarily during testing.
  3. Potential Issues:

    • The -blocks-storage.bucket-store.ignore-blocks-within=0s setting may lead to unexpected behaviour if blocks are ignored immediately. Review the implications of this setting in your context.
    • The -auth.no-auth-tenant=anonymous setting should be reviewed for security implications, especially in production environments.
  4. General Observations:

    • The changes appear to be well-structured and follow a logical progression. Ensure that all new configurations are tested in a staging environment before deploying to production.

No other issues or suggestions were noted in the modified lines.

> gpt-4o-mini [pr | 0]

@saidsef saidsef merged commit 9e31768 into main Jul 29, 2024
5 checks passed
@saidsef saidsef deleted the mimir-compactor branch July 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant