Doesn't restrict popup options to width and height #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`width` and `height` are very restrictive popup options. When used in conjunction with `cordova.inAppBrowser` there are [many possible options](https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-inappbrowser/#cordovainappbrowseropen) which could be very interesting to pass... For example, by passing `clearcache` and `clearsessioncache` in `popupOptions`, it prevents the problem we have with `cordova.inAppBrowser` where we connect to a provider one first time, then stay connected forever inside the in app browser, and are unable to logout or change user without re-install the entire app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthandheightare very restrictive popup options.When used in conjunction with
cordova.inAppBrowserthere are many possible options which could be very interesting to pass...For example, by passing
clearcacheandclearsessioncacheinpopupOptions, it preventsthe problem we have with
cordova.inAppBrowserwhere we connect to a providerone first time, then stay connected forever inside the in app browser, and are
unable to logout or change user without re-install the entire app.