-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
24 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7933978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Missing semicolons and
var
's -- it's apparent that it's been a while since I've worked in vanilla JS!On a sidenote, I didn't want to introduce to much as part of this PR, but additionally using something like Sinon might be useful for sandboxing changes as to not affect the overall state of the configuration (eg. so resetting like in L58 isn't necessary).