Fix duplicate install of config.py in meson build #38867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Documentation preview for this PR (built with commit 32971da; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2024
The `configure_file` command creating this `config.py` file already has
`install: true` which makes it installed by default. Installing it again
here creates a duplicate entry in wheel packages, which breaks
installing them with some tools (eg. python-installer).
URL: sagemath#38867
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configure_filecommand creating thisconfig.pyfile already hasinstall: truewhich makes it installed by default. Installing it again here creates a duplicate entry in wheel packages, which breaks installing them with some tools (eg. python-installer).