remove some unused variables #38861
Open
remove some unused variables #38861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit a88db61; changes) is ready! 🎉 |
dcoudert
reviewed
Oct 27, 2024
| @@ -591,7 +591,7 @@ def _sage_input_(self, sib, coerced): | |||
| """ | |||
| if self._ambient is not self: | |||
| raise NotImplementedError | |||
| data = self._vertices | |||
| _ = self._vertices | |||
There was a problem hiding this comment.
good point. I am not sure.
|
so positive review ? |
|
yes |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2024
found using
`ruff check --select=F841 --output-format=concise src/sage/`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38861
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found using
ruff check --select=F841 --output-format=concise src/sage/📝 Checklist