Turn some doctests in ell_rational_field.py into long tests
#38824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit c5828ca; changes) is ready! 🎉 |
|
probably a side-effect of #38461 |
fchapoton
reviewed
Oct 18, 2024
| sage: P = E.lift_x(611429153205013185025/9492121848205441) | ||
| sage: ge = set(E.gens(use_database=False, algorithm='pari',pari_effort=4)) | ||
| sage: ge <= set([P+T for T in E.torsion_points()] |
There was a problem hiding this comment.
why gather the lines here ?
There was a problem hiding this comment.
Marking just the first line as # long time caused a warning that ge is not always defined
|
I can't reproduce the timeout of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38813
Some of the doctests in
ell_rational_field.pyran into RuntimeErrors and couldn't compute generators in time, causing tests to fail. Turning them into long tests (which is necessary since they have to run longer in some cases) fixes that problem.Also added some missing spaces.