Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-lock.py script to compile requirements using pip-tools #37463

Closed
wants to merge 6 commits into from

Conversation

tobiasdiez
Copy link
Contributor

We add a litle wrapper around pip-compile that transforms the abstract version constraints of #37446 into pinned version specifications in requirement.txt files (see #37461 for the result).

The PR #37446 is sadly on the pile of PRs disputed by Matthias, so I'll not add it as an explicit dependency. The script can be tested with python tools/update-lock.py src (after pip install pip-tools) although it then does not generate the test/doc/linter-requirment.txt files of #37461.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Feb 25, 2024
Copy link

github-actions bot commented Mar 10, 2024

Documentation preview for this PR (built with commit 49e68c6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 15, 2024

@roed314 @jhpalmieri I set "disputed" here because when the PR was opened, I was not able to comment because Tobias had blocked me without explanation or giving notice to the sage-abuse committee. It appears that now I can comment, so I am removing "disputed".
There has not been any review yet here, so conducting a vote would seem premature.

@mkoeppe mkoeppe removed the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Mar 15, 2024
@tobiasdiez
Copy link
Contributor Author

This is now included in #37461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants