Trivial simplifications for arccos #36069
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of places where arccos doesn't automatically simplify for ratios arising from the unit circle (but arcsin does).
Turns out that in
src/sage/symbolic/ginac/inifcns_trig.cpp
,asin_eval
has some logic handling unit circle cases directly that was not replicated inacos_eval
. I copy-pasted the logic fromasin_eval
and modified appropriately.Partially fixes #24211.
I'm not sure exactly how to create tests covering this change but would be happy to do so with a little guidance!
📝 Checklist
⌛ Dependencies
None!