Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade protocol-kit to v5 #4333

Closed
wants to merge 1 commit into from

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 8, 2024

What it solves

Upgrades to protocol-kit v5.

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 8, 2024

Branch preview

❌ Deploy failed!

Copy link

github-actions bot commented Oct 8, 2024

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🟡 Statements
77.91% (+0% 🔼)
12373/15881
🔴 Branches
58.24% (+0.03% 🔼)
3239/5561
🟡 Functions
65.16% (+0.06% 🔼)
1947/2988
🟡 Lines
79.42% (+0% 🔼)
11166/14060
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / useIsValidExecution.ts
65.85% (-5.26% 🔻)
60% (+1.67% 🔼)
60%
63.16% (-8.27% 🔻)
🟢
... / ContractErrorCodes.ts
66.67% (-33.33% 🔻)
100% 100% 100%

Test suite run failed

Failed tests: 1/1557. Failed suites: 1/205.
  ● useIsValidExecution › should append the error code description to the error thrown

    expect(received).toBe(expected) // Object.is equality

    Expected: "GS026: Invalid owner provided"
    Received: undefined

      91 |
      92 |     expect(isValidExecution).toBe(undefined)
    > 93 |     expect((executionValidationError as EthersError)?.reason).toBe('GS026: Invalid owner provided')
         |                                                               ^
      94 |     expect(isValidExecutionLoading).toBe(false)
      95 |   })
      96 | })

      at Object.toBe (src/features/recovery/hooks/__tests__/useIsValidExecution.test.ts:93:63)

Report generated by 🧪jest coverage report action from ae47dec

@schmanu
Copy link
Member Author

schmanu commented Oct 8, 2024

Closing this for now in favor of #4334

@schmanu schmanu closed this Oct 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant