-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multichain] fix: Add more analytics events for multichain [SW-165] #4311
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
987.32 KB (🟡 +26.1 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fifteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
511 B (🟢 -24.37 KB) |
987.82 KB |
/address-book |
26.09 KB (🟡 +5 B) |
1013.41 KB |
/apps/open |
53.09 KB (-1 B) |
1.02 MB |
/balances |
29.42 KB (🟢 -1.52 KB) |
1016.73 KB |
/balances/nfts |
19.18 KB (-1 B) |
1006.5 KB |
/home |
57.22 KB (🟢 -924 B) |
1.02 MB |
/new-safe/advanced-create |
36.49 KB (🟡 +1.36 KB) |
1023.81 KB |
/new-safe/create |
35.75 KB (🟡 +1.35 KB) |
1023.07 KB |
/new-safe/load |
16.41 KB (🟡 +6 B) |
1003.73 KB |
/settings/modules |
9.82 KB (🟡 +38 B) |
997.14 KB |
/settings/notifications |
27.03 KB (-2 B) |
1014.34 KB |
/settings/setup |
35.98 KB (🟡 +5 B) |
1023.3 KB |
/transactions/tx |
21.07 KB (-2 B) |
1008.39 KB |
/welcome |
6.8 KB (🟢 -1 B) |
994.12 KB |
/welcome/accounts |
379 B (🟢 -1 B) |
987.69 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1541 tests passing in 205 suites. Report generated by 🧪jest coverage report action from 695803c |
@@ -55,11 +55,16 @@ const SubAccountItem = ({ onLinkClick, safeItem, safeOverview }: SubAccountItem) | |||
|
|||
const cfSafeSetup = extractCounterfactualSafeSetup(undeployedSafe, chain?.chainId) | |||
|
|||
const onSwitchSafe = () => { | |||
trackEvent({ ...OVERVIEW_EVENTS.SWITCH_NETWORK, label: chainId }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switch network the correct event here?
I could also switch to another Multichain Safe and therefore switch Safe and network or only switch to another Safe on the same network.
Maybe we should call it "choose Safe from sidebar" or something like that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine here since its in the SubAccountItem
so only emitted if the user switches between the same safe on a different network. I added this to match the network selector in the header which also allows switching between the same safe on different networks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I can open a SubAccountItem
of a different Safe.
So for instance switch from Safe "0x00...01" on Gnosis Chain to Safe "0x00...02" on Polygon.
Also now its impossible to distinguish between switching networks in the sidebar or through the network selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Maybe we should leave it out then since we already emit an Open Safe
when a Safe is opened from the Sidebar.
What it solves
Resolves SW-165
How this PR fixes it
How to test it
Check that the events described in SW-165 are emitted correctly
Checklist