Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long token name visible over balance #4121

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Shaik-Sirajuddin
Copy link
Contributor

What it solves

Resolves #3438

How this PR fixes it

Truncate text for long token names

How to test it

1)Execute a transaction to transfer Erc20 (any) tokens via SafeWallet
2)Edit the token name via html to a long text ( alternatively deploy a token with long name and use it for transfer)
3)Token Name overlaps with other fields

Screenshots

Before :
Desktop :
Screenshot from 2024-08-28 18-42-34
Mobile :
Screenshot from 2024-08-28 18-41-59
After :
Desktop :
Screenshot from 2024-08-28 18-42-51
Mobile :
Screenshot from 2024-08-28 18-40-22

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Aug 28, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@@ -29,11 +29,13 @@ export const TransferTx = ({
omitSign = false,
withLogo = true,
preciseAmount = false,
truncateText = false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component is being used in various pages

truncate text is applied specifically to in transaction info component , to avoid unindented UI changes in other pages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide to truncate text everywhere in #4034 (comment)?

@Shaik-Sirajuddin
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Shaik-Sirajuddin
Copy link
Contributor Author

recheck

Safe-infra added a commit to safe-global/cla-signatures that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long token names cover the balance
2 participants