Tests: Fix hp tests #4024
Merged
Tests: Fix hp tests #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1447 tests passing in 200 suites. Report generated by 🧪jest coverage report action from 58f9f0f |
liliya-soroka
approved these changes
Aug 2, 2024
katspaugh
reviewed
Aug 2, 2024
| @@ -62,7 +62,8 @@ function executeTransaction() { | |||
| } | |||
|
|
|||
| function addToBatchButton() { | |||
| cy.contains(addToBatchBtn).should('be.visible').and('not.be.disabled').click() | |||
| cy.wait(1000) | |||
There was a problem hiding this comment.
I don't think this timeout is necessary. The button is rendered immediately, it's just not in the viewport.
katspaugh
reviewed
Aug 2, 2024
| @@ -62,7 +62,8 @@ function executeTransaction() { | |||
| } | |||
|
|
|||
| function addToBatchButton() { | |||
| cy.contains(addToBatchBtn).should('be.visible').and('not.be.disabled').click() | |||
| cy.wait(1000) | |||
| cy.get('button').contains(addToBatchBtn).scrollIntoView().should('not.be.disabled').click() | |||
There was a problem hiding this comment.
Here you don't check if the button is visible, so no need to scroll to it either.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
How this PR fixes it
How to test it