-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: malicious recovery detection #3834
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
I guess it's a regression after #3811. So we cannot just always use the latest multisend contract? |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1436 tests passing in 199 suites. Report generated by 🧪jest coverage report action from 23cdfa0 |
We use the version that we pass to the safe-core-sdk. But if that version has no MultiSendCallOnly contract it falls back to 1.3.0. |
Closing this as we reverted the change that caused this issue. |
What it solves
Resolves https://www.notion.so/safe-global/Recovery-tx-is-being-considered-a-malicious-tx-724664e7de4e4a8da4d88b5606af047c?pvs=4
How this PR fixes it
How to test it
Checklist