Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sidebar info chip styles consistent #3805

Closed
wants to merge 7 commits into from
Closed

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Jun 6, 2024

What it solves

Resolves :https://www.notion.so/safe-global/Align-chip-styles-7ab45b9ab8d34c5c909dd60e48cc301c?pvs=4

How this PR fixes it

  • gives both the pending txs chip and the 'new' chip a left/right padding of 8px.
  • gives them both the same font height and font weight.
  • changes the color of the pending txs chip to 'warning-light'

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@jmealy jmealy requested a review from compojoom June 6, 2024 10:01
Copy link

github-actions bot commented Jun 6, 2024

Copy link

github-actions bot commented Jun 6, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jun 6, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.45 KB (🟡 +104 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Jun 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.48% 11507/14477
🔴 Branches 58.57% 2767/4724
🟡 Functions 66.77% 1851/2772
🟢 Lines 80.83% 10379/12840

Test suite run success

1443 tests passing in 199 suites.

Report generated by 🧪jest coverage report action from 0d27bc1

Copy link

Align chip styles

@compojoom
Copy link
Collaborator

@jmealy can you maybe build this PR on top of this one: https://github.com/safe-global/safe-wallet-web/pull/3771/files

Since now we are showing this "new" label on several places we've refactored our Chip component so your changes should go there.

@jmealy jmealy changed the base branch from dev to feat-promo-widget-swaps June 6, 2024 15:50
@jmealy jmealy changed the base branch from feat-promo-widget-swaps to dev June 6, 2024 15:50
@jmealy
Copy link
Contributor Author

jmealy commented Jun 6, 2024

@jmealy can you maybe build this PR on top of this one: https://github.com/safe-global/safe-wallet-web/pull/3771/files

Since now we are showing this "new" label on several places we've refactored our Chip component so your changes should go there.

Made the changes on your branch, closing this

@jmealy jmealy closed this Jun 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants