-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: make sidebar info chip styles consistent #3805
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
950.45 KB (🟡 +104 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1443 tests passing in 199 suites. Report generated by 🧪jest coverage report action from 0d27bc1 |
@jmealy can you maybe build this PR on top of this one: https://github.com/safe-global/safe-wallet-web/pull/3771/files Since now we are showing this "new" label on several places we've refactored our Chip component so your changes should go there. |
Made the changes on your branch, closing this |
What it solves
Resolves :https://www.notion.so/safe-global/Align-chip-styles-7ab45b9ab8d34c5c909dd60e48cc301c?pvs=4
How this PR fixes it
Screenshots
Checklist