-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: improve chain switch redirect #3769
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
950.05 KB (🟡 +35 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Had to read the conversation in the review to understand what it was the purpose of the ticket. LGTM It seems this only happens if the user is connected. I think diconnected users also can be taken to the /welcome/accounts page since the user might have safes in his watchlist, but is not a blocker |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1437 tests passing in 197 suites. Report generated by 🧪jest coverage report action from 645eec6 |
What it solves
After we removed the automatic redirect from
/welcome
to/welcome/accounts
if wallet is connected, the Network Selector started requiring an extra click to see the list of your Safes. This PR fixes that.The Network Select will now take you straight to
/welcome/accounts
if wallet is connected.