Release 1.37.1 #3766

katspaugh · 2024-05-29T10:30:30Z

Features

feat: add new label to swaps button (Release 1.37.1 #3766)

Analytics

Differentiate bulk executions from batches (Analytics: differentiate bulk executions from batches #3779)
fix: Safe stats tracking for owned Safes (fix: Safe stats tracking for owned Safes #3708)
fix: counterfactual safe tracking (fix: counterfactual safe tracking #3783)

Bug fixes

WalletConnect
- fix: (WC) do not return Safe as available on all optional Namespaces (fix: (WC) do not return Safe as available on all optional Namespaces #3725)
- Fix: Show loading state in WC input between pairing and receiving proposal (Fix: Show loading state in WC input between pairing and receiving proposal #3712)
Fix: back button style (Fix: back button style #3742)
Fix: missing feature toggles (Fix: missing feature toggles #3748)
fix: do not show nonce conflict warning for batch transactions. (fix: do not show nonce conflict warning for batch transactions. #3608)
Fix: rearrange Settings tabs (Fix: rearrange Settings tabs #3751)
Fix: memoize Safe List data (Fix: memoize Safe List data #3729)
Fix: move rhino.fi to warned bridges (Fix: move rhino.fi to warned bridges #3740)
fix: Hide signed transaction from untrusted pending queue (fix: Hide signed transaction from untrusted pending queue #3710)
fix: Add network to Rabby if unknown (fix: Add network to Rabby if unknown #3776)

Chores & tests

Chore: remove social login (Chore: remove social login #3753)
Chore: remove batch reordering (Chore: remove batch reordering #3754)
Chore: update release action (Chore: update release action #3739)
Tests: add component tests for tx history filter (Tests: add component tests for tx history filter #3758)
Chore: use separate Infura tokens for dev (Chore: use separate Infura tokens for dev #3773)
Chore: fix branch conditionals (Chore: fix branch conditionals #3782)

* fix: Hide signed transaction from untrusted pending queue * fix: Revert label adjustment, extract logic from hook and write tests * refactor: Filter items first

…posal (#3712) * fix: show loading state in WC widget between pairing and receiving a proposal * fix: clear loading state on failed paring * empty commit for deployment * disable loading state for approval form * fix typo * add 30 second timeout for proposal * Only show timeout error when waiting on proposal

* Fix: update social login disclaimer * Prettier

…3725)

* Fix: memoize Safe List data * Adjust types

* tests: add component tests for tx history filter * tests: update tests

Bumps [next](https://github.com/vercel/next.js) from 14.1.0 to 14.1.1. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.1.0...v14.1.1) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

github-actions · 2024-05-29T10:30:46Z

Branch preview

⏳ Deploying a preview site...

github-actions · 2024-05-29T10:31:37Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-05-29T10:34:14Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions · 2024-05-29T10:36:51Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	79.47% (+0.21% 🔼)	11295/14213
🔴	Branches	58.46% (+0.3% 🔼)	2699/4617
🟡	Functions	66.67% (+0.36% 🔼)	1822/2733
🟢	Lines	80.85% (+0.24% 🔼)	10185/12597

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / index.tsx	100%	93.1%	100%	100%
🟢	`...` / index.tsx	94.44%	87.5%	100%	94.12%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / web3.ts	63.27% (-8.16% 🔻)	8.33% (-16.67% 🔻)	28.57% (-28.57% 🔻)	57.89% (-10.53% 🔻)
🟢	src/utils/chains.ts	88.89% (-2.78% 🔻)	83.33% (-16.67% 🔻)	100%	100%
🟡	`...` / sdk.ts	69.79% (-1.18% 🔻)	38.1% (-4.01% 🔻)	69.23%	68.6% (-1.27% 🔻)
🟢	`...` / consts.ts	66.67% (-33.33% 🔻)	100%	100%	100%
🔴	`...` / useOnboard.ts	44.63% (-6.15% 🔻)	11.11% (-12.7% 🔻)	15%	47.66% (-5.85% 🔻)
🟢	`...` / useSafeCreation.ts	90% (-0.12% 🔻)	84.38%	55.56%	90.67% (-0.12% 🔻)
🟢	`...` / safeTheme.ts	90.7% (-2.16% 🔻)	50%	90% (-3.1% 🔻)	92.68% (-2.32% 🔻)
🟢	`...` / usePendingTxs.ts	89.58%	82.35% (-0.98% 🔻)	92.31% (+1.4% 🔼)	92.5%
🟢	`...` / WalletConnectWallet.ts	90.36% (-0.11% 🔻)	89.47% (-1% 🔻)	84%	92.41% (-0.09% 🔻)
🔴	`...` / index.tsx	24.44% (-31.11% 🔻)	0% (-19.05% 🔻)	14.29% (-28.57% 🔻)	24.39% (-29.27% 🔻)
🟡	`...` / index.tsx	66.67% (-22.22% 🔻)	0% (-50% 🔻)	0% (-66.67% 🔻)	75% (-12.5% 🔻)
🔴	`...` / useAllOwnedSafes.ts	38.89% (-2.29% 🔻)	0%	0%	41.18% (-8.82% 🔻)
🟢	`...` / index.tsx	87.5% (-12.5% 🔻)	100%	100%	100%
🟡	`...` / index.tsx	76.53% (-1.77% 🔻)	53.13% (+1.96% 🔼)	72.73%	77.17% (-1.83% 🔻)
🟢	`...` / index.tsx	92.86% (-7.14% 🔻)	100%	100%	100%
🟢	`...` / index.tsx	88.89% (-0.58% 🔻)	85.71% (-5.95% 🔻)	75% (+15% 🔼)	87.5% (-3.68% 🔻)

Test suite run success

1436 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 7537a62

francovenica · 2024-05-29T15:37:43Z

Board for feedback: https://www.notion.so/safe-global/1f1df3f06ead4378ab1c9c3de24951b1?v=6ad2667b868d4c0f8cf18e129f762583&p=fe77f270babe4b2084ab70f07b7cc5a3&pm=s

* feat: add new label to swaps button

github-actions · 2024-05-30T14:18:11Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2024-05-31T04:26:58Z

Question regarding the infura token for dev.
Currently in the PR where this was developed initially, the infura URL you can see in the settings is, as expected, different than the one in current prod
The thing is that after merging that to the release, the infura URL in the settings is the same as the one in current prod. Could this be because the release branch is tagged as prod? or should this release also have the same infura URL in the settings as the original PR and we have an issue?

francovenica · 2024-05-31T04:35:55Z

I tried to check that las commit regarding the change in how tx in bulk is tracked in analytics, but I don't see any GTM calls all of the sudden. Those were there before since I even reported an issue about them in the board.
Any recent changes that might have disable/hide them from showing up in the dev console?

katspaugh · 2024-05-31T06:15:18Z

@francovenica yes, exactly, the RC branches will use all the production settings. CGW will also be the prod version.

francovenica · 2024-05-31T15:53:02Z

It seems that the GTM calls are not being shown anymore because now the release branch is "like prod".

I went back to the PR's that did the changes in the GTM tracks 3779 and 3783 and test those fixed there and they work fine.

francovenica · 2024-05-31T15:55:18Z

The rest of the regression went fine, and the last commits were checked and they worked fine.

There is an ongoing discussion if we should keep the "use different infura for dev" change, so if it is decied to roll back that change let me know

If not, then the RC looks good for release

github-actions · 2024-06-03T07:43:31Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

usame-algan and others added 17 commits May 24, 2024 09:47

fix: Hide signed transaction from untrusted pending queue (#3710)

c60895f

* fix: Hide signed transaction from untrusted pending queue * fix: Revert label adjustment, extract logic from hook and write tests * refactor: Filter items first

Fix: move rhino.fi to warned bridges (#3740)

1733f18

Chore: update release action (#3739)

72a2018

Fix: update social login disclaimer (#3741)

98e879a

* Fix: update social login disclaimer * Prettier

fix: (WC) do not return Safe as available on all optional Namespaces (#…

433bb16

…3725)

Fix: memoize Safe List data (#3729)

548bf6a

* Fix: memoize Safe List data * Adjust types

fix: Safe stats tracking for owned Safes (#3708)

ae506ee

Chore: remove batch reordering (#3754)

6e794e4

Tests: add component tests for tx history filter (#3758)

53162c6

* tests: add component tests for tx history filter * tests: update tests

Fix: rearrange Settings tabs (#3751)

e1156b6

fix: do not show nonce conflict warning for batch transactions. (#3608)

f1bad1f

Chore: remove social login (#3753)

01878b5

Fix: missing feature toggles (#3748)

1822efd

Fix: back button style (#3742)

5fe39f1

1.37.0

050e58b

katspaugh requested a review from schmanu May 29, 2024 10:30

liliya-soroka assigned francovenica May 29, 2024

compojoom and others added 3 commits May 29, 2024 18:00

feat: add new label to swaps button [SWAP-86] (#3763)

3da9a4e

* feat: add new label to swaps button

fix: Add network to Rabby if unknown (#3776)

4f57526

Chore: use separate Infura tokens for dev (#3773)

b452828

mike10ca and others added 2 commits May 30, 2024 16:34

Tests: add tx filter tests (#3781)

146b394

Analytics: differentiate bulk executions from batches (#3779)

a7b60f4

Chore: fix branch conditionals (#3782)

d5f5adb

schmanu and others added 2 commits May 31, 2024 10:02

fix: counterfactual safe tracking (#3783)

7537a62

Fix: remove the New chip from Recovery settings (#3785)

1f6e2b6

1.37.1

be5d931

katspaugh changed the title ~~Release 1.37.0~~ Release 1.37.1 Jun 3, 2024

katspaugh merged commit be5d931 into main Jun 3, 2024
13 of 16 checks passed

katspaugh deleted the release branch June 3, 2024 07:44

github-actions bot locked and limited conversation to collaborators Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.37.1 #3766

Release 1.37.1 #3766

katspaugh commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

francovenica commented May 29, 2024

github-actions bot commented May 30, 2024 •

edited

Loading

francovenica commented May 31, 2024

francovenica commented May 31, 2024

katspaugh commented May 31, 2024

francovenica commented May 31, 2024

francovenica commented May 31, 2024

github-actions bot commented Jun 3, 2024

Release 1.37.1 #3766

Release 1.37.1 #3766

Conversation

katspaugh commented May 29, 2024 • edited Loading

Features

Analytics

Bug fixes

Chores & tests

github-actions bot commented May 29, 2024 • edited Loading

Branch preview

github-actions bot commented May 29, 2024

ESLint Summary View Full Report

github-actions bot commented May 29, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

github-actions bot commented May 29, 2024 • edited Loading

Coverage report

Test suite run success

francovenica commented May 29, 2024

github-actions bot commented May 30, 2024 • edited Loading

ESLint Summary View Full Report

francovenica commented May 31, 2024

francovenica commented May 31, 2024

katspaugh commented May 31, 2024

francovenica commented May 31, 2024

francovenica commented May 31, 2024

github-actions bot commented Jun 3, 2024

ESLint Summary View Full Report

katspaugh commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 30, 2024 •

edited

Loading