Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use zero swap amount from assets table [SWAP-83] #3761

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented May 28, 2024

What it solves

SWAP-83

How this PR fixes it

  • Sets amount to 0

How to test it

Click on swap button on assets list

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from compojoom May 28, 2024 13:08
Copy link

Copy link

github-actions bot commented May 28, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.17 KB (🟢 -21 B) 1.05 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.28% (-0.12% 🔻)
11627/14665
🔴 Branches
58.14% (-0.3% 🔻)
2751/4732
🟡 Functions
66.38% (-0.19% 🔻)
1866/2811
🟢 Lines
80.62% (-0.12% 🔻)
10478/12996
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
96.15% (-3.85% 🔻)
87.5% (-12.5% 🔻)
100%
95.65% (-4.35% 🔻)
🟢
... / tx-history-filter.ts
100%
85.71% (-2.86% 🔻)
100% 100%
🟢
... / index.tsx
96.67% (-0.05% 🔻)
72.22% 76.92%
96.55% (-0.06% 🔻)

Test suite run success

1468 tests passing in 202 suites.

Report generated by 🧪jest coverage report action from d6e2260

Copy link
Collaborator

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's so sad.

@francovenica francovenica self-assigned this Jun 3, 2024
@francovenica
Copy link
Contributor

LGTM

@compojoom compojoom merged commit ac90a1f into dev Jun 4, 2024
14 checks passed
@compojoom compojoom deleted the fix/swap-amount-zero branch June 4, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants