-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: display contract names for WalletConnect txs #3760
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1438 tests passing in 197 suites. Report generated by 🧪jest coverage report action from 4bacced |
Looks like Usame has partially reviewed it, so I'll provisionally move it to QA but happy to make any requested changes later. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
@francovenica the example you gave me has different txs on prod and staging. Nonce 378 on staging is not a Cow tx, and it's the same tx as nonce 380 with the prod CGW. So there's no issue there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to show the Domains for WalletConnect messages!
@katspaugh Check in both snapshots the TxHash, is the same, so it is the same transaction |
@francovenica I see, true! Still, the issue there is a prod/dev mismatch. Safe App ids are different across these environments, so a tx made in one env won't match with the same (if any) Safe App in another. If you switch the prod CGW toggle, tx 378 gets the correct icon. |
What it solves
For transactions made via WalletConnect, show the contract name instead of just WalletConnect in the tx summary.
How this PR fixes it
I've changed the
appUrl
or these txs from a hard-coded WalletConnect Safe App URL to the original dapp URL.Since our backend doesn't know anything about arbitrary dapp origins, it will not be able to annotate these txs as WalletConnect txs anymore, so we'll display a generic contract name instead. If the contract isn't verified, it will just say Contract interaction as usual.
How to test it
Screenshots
Before
After