-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: rearrange Settings tabs #3751
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Test suite run success1468 tests passing in 202 suites. Report generated by 🧪jest coverage report action from 28c02dc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There is a lint error and a test is failing tho.
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Page AddedThe following page was added to the bundle from the code in this PR:
Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Do we also need to adjust e2e tests for spending limits not that it was moved to a different page? |
Not 100% sold on putting the spending limit on setup, since it doesn't show right away (you have to scroll down to see it). I'd put it in its own tab since is a very specific feature. |
LGTM |
I agree regarding a separate tab for limits. There's a bigger project in the works to revamp the settings, so it will be addressed there. |
What it solves