Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: back button style #3742

Merged
merged 3 commits into from
May 29, 2024
Merged

Fix: back button style #3742

merged 3 commits into from
May 29, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3717

How this PR fixes it

Make the Back button in the tx modal look consistent with the same button in Safe Creation.

How to test it

  • Create a new tx
  • Proceed to the Sign step

Test both on mobile and desktop.

Screenshot 2024-05-24 at 12 06 00

@katspaugh katspaugh requested a review from jmealy May 24, 2024 10:07
Copy link

github-actions bot commented May 24, 2024

Branch preview

⏳ Deploying a preview site...

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 24, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 949.92 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.23 KB (🟡 +1 B) 979.16 KB
/home 57.4 KB (-2 B) 1007.33 KB
/new-safe/create 26.67 KB (🟢 -5 B) 976.59 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.27% (+0.01% 🔼)
11631/14673
🔴 Branches
58.18% (+0.02% 🔼)
2753/4732
🟡 Functions 66.33% 1866/2813
🟢 Lines
80.62% (+0.01% 🔼)
10482/13001

Test suite run success

1468 tests passing in 202 suites.

Report generated by 🧪jest coverage report action from 6c1291e

@francovenica
Copy link
Contributor

Now that the button has a border, for mobile we should make it as big as the "confirm"/"sign"/"next" button of the form.

image
image

This is how it looks in prod. By not having a border there it didn't look like a small button how it looks now:
image
image

Copy link

github-actions bot commented May 29, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member Author

Good catch! I've restored the "text" style on small screens.

Screenshot 2024-05-29 at 11 56 13

@katspaugh katspaugh merged commit 5fe39f1 into dev May 29, 2024
10 of 13 checks passed
@katspaugh katspaugh deleted the back branch May 29, 2024 09:57
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace primary button with the secondary one on the confirmation screen
3 participants