Release 1.31.0 #3391
Merged
Release 1.31.0 #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tests: fix breaking tests
* fix: Address overflow on transaction history * fix: Add hide address overflow on safe accounts list * refactor: Modify move style to container class
Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: wc no matching key: keychain This seems to be fixed with this PR: WalletConnect/walletconnect-monorepo#4139 so that is why I force a newer WC version since web3-onboard doesn’t have a release that uses it. * fix: wc no matching key. session This is an attempt to fix this WC error, but it doesn’t always work. Even more this error is reproducible only with 1inch. Steps to reproduce the error: 1. Open your safe and login into an account 2. Open 1inch and select connect with walletconnect 3. On your safe, paste the link in the wc pairing field, but don’t approve 4. Refresh the page 5. Get a new pairing link from 1inch and try to pair again 6. You get the error With the fix in this commit, we clean up on page unload this way the localstorage of walletconnect is left with an empty propsal and the next time the user tries to approve it should work. This is only a workaround. I think that this is a bug in walletconnect and they should better take care of their localstorage.
* Add noindex meta tag to prevent search engine indexing * Update src/components/common/MetaTags/index.tsx Co-authored-by: katspaugh <[email protected]> --------- Co-authored-by: katspaugh <[email protected]>
* feat: add husky pre-push hook Prior to pushing to remote, check and fix any linting issues. If an issue was found and fixed, we’ll prevent the user from pushing - he would have to commit the changed files. If you want to run the test suite on pushing you can set the RUN_TESTS_ON_PUSH variable to true. Co-authored-by: katspaugh <[email protected]>
update typescript to version 5.3.3
* tests: add safe creation tests * tests: remove duplicate test
* Fix: remove broken index redirect * Redirect from Welcome to Accounts only on explicit Connect * Adjust smoke test
…3310) * feat: add labels to tracking events for the login flow * remove unecessary util function * fix: use correct tracking labels for login_page and sidebar * simplify data import/export events * fix: [RC] Add pay later hint to safe creation step (#3305) * fix: Turn off copy prefix by default and show toggle in first steps widget * fix: Change 1/1 hint to an info box Show message about Pay later feature Remove unused NetworkWarning from owner step * tests: fix breaking test * fix: Adjust wording for 1/1 hint and pay later hint --------- Co-authored-by: mike10ca <[email protected]> * fix: show newly depoyed safes under owned safes (#3308) * fix: show newly depoyed safes under owned safes * Update src/components/welcome/MyAccounts/useAllSafes.ts Co-authored-by: katspaugh <[email protected]> * fix: add missing import --------- Co-authored-by: katspaugh <[email protected]> * Show remove from watchlist option when viewing a watchlist safe (#3307) * Show remove option when safe is already added to the watchlist * remove trash icon from remove button * add tracking for removeing from wtchlist * fix: remove duplicate event * fix: typo in remove from watchlist event * fix: add missing labels and events * fix: incorrect label for deleted from watchlist event --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: mike10ca <[email protected]> Co-authored-by: katspaugh <[email protected]>
* tests: add revised tests for import export * tests: remove unused import * tests: update test logic
Since the .listItem had a padding, the <a> tag inside of it was only clickable if you manage to hit it directly. But ListItem actually looks like a clickable button, so you won’t expect that you have to be clicking directly in the center.
…nts page (#3376) * index route redirects to login page if there are safes stored locally * fix: update unit tests for WalletLogin
* show all safes after clicking show more * remove show more button
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1015.86 KB (🟡 +3 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show files with reduced coverage 🔻
Test suite run success1410 tests passing in 195 suites. Report generated by 🧪jest coverage report action from b29dc9c |
|
Regression run - 9 failed cases that should be checked and updated - https://github.com/safe-global/safe-wallet-web/actions/runs/8157710372 |
liliya-soroka
requested review from
francovenica,
schmanu,
jmealy and
mike10ca
and removed request for
francovenica
- Fixes gas estimation for execution transaction - Fixes gas estimation for on-chain signature transaction Co-authored-by: schmanu <[email protected]>
* tests: add happy path flows for recovery v1 * tests: remove unused import * tests: fix failing tests * tests: update test folders * tests: update tests and balance fixture file
ESLint Summary View Full Report
Report generated by eslint-plus-action |
… non-owners (#3398) * fix: Track Create new Safe click once * fix: Disable Add funds and Create transaction buttons for non-owners
- fix: detect native transfers - add unit tests for decoded tx
* remove dynamic sorting by current chain for safe lists * fix: useMemo dependency array * fix: remove unused variable
* fix: Add wrap on queue tx button container * style: Remove unnecesary template strings
* tests: update number of machines for recovery tests
ESLint Summary View Full Report
Report generated by eslint-plus-action |
* Fix: don't fetch manifest for unknown Safe Apps * Update e2e tests * Fix tx_modal test
…s in localstorage (#3399) * fix:index redirect happens before checking localstorage for safes * fix: access local safes directly from localstorage to have value on initial render * fix: incorrect redirect after adding and then removing a safe * use local storage service to access added safes * add to do to use localstorage hook * use existing localstorage key for added safes
…ogin page (#3364) * feat: track number of owned safes and watchlist safes when the user visits the login page * fix: only send events on login page load * extrack tracking logic into a hook * fix: track events only on first visit to accounts page or on reloading the app
usame-algan
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe List improvements
/to accounts page (Feat: if there are local safes redirect from index route/to accounts page #3376)Analytics
Bug fixes
Chores and tests