-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: don't load social login if no env var is set #3267
Conversation
With our default .env variables we would end up trying to parse the empty string and we’ll end up in the catch case. No need to polute the console with this.
If we haven’t configured any SOCIAL_WALLET_OPTIONS we don’t need to worry about the chain.
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.03 MB (🟡 +1.07 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show files with reduced coverage 🔻
Test suite run success1404 tests passing in 191 suites. Report generated by 🧪jest coverage report action from 18f58bb |
What it solves
Resolves #
We should be able to start the app by just providing the infura token and nothing else.
How this PR fixes it
If we haven't specified any social_wallet_options, the social login is not enabled.
How to test it
You shouldn't get an error now when you run
yarn dev
Screenshots
Checklist