-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: avoid fetching Safe Apps on all pages #3254
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eight Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1402 tests passing in 191 suites. Report generated by 🧪jest coverage report action from d1436b7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same is required for the Safe Governance app.
We fetch the Safe Apps for the widget in the header to link to the Safe app.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vamos!
@katspaugh , have we returned WalletConnect safe app ? (prod CGW)
|
@liliya-soroka this can happen when you use the prod CGW switch. Let me fix it. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
I've checked that the apps still work fine. Tried connecting with opensea and singing the message I didn't have any issues. |
What it solves
Resolves #3253
How this PR fixes it
The "native" WalletConnect feature has to annotate its transactions as if they were coming from the legacy WalletConnect Safe App. This is to ensure that the transaction service adds the correct icon and name to these transactions in the history and queue.
To avoid making an extra request just to fetch the WC Safe App id and URL, I suggest we hardcode it for now. We should solve the root cause of this dependancy on a legacy Safe App on the backend.