-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: redesign Safe List in sidebar #3245
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Twenty-three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1397 tests passing in 191 suites. Report generated by 🧪jest coverage report action from 6c1d3f8 |
* redesign data widget * adjust margins * add separator and fix padding * move data widget to MyAccounts and remove SafeListDrawer * remove unecessary padding * remove unused styles * do not wait for safes list on welcome page in cypress tests
* display new safe list in sidebar * align chain indicators in the sidebar * add styles for currently open safe in the sidebar close drawer after choosing a safe in the sidebar * remove duplicate definition of isSidebar * fix: css formatting * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/AccountItem.tsx Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/AccountItem.tsx Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/index.tsx Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * Update src/components/welcome/MyAccounts/styles.module.css Co-authored-by: katspaugh <[email protected]> * use container queries to apply styles to sidebar * hide Chain indicator name in reponsive mode * add watchlist to my accounts page * separate pagination for watchlist and owned safes * add watchlist flag * filter out watchlist from owned safes * rename adding a safe to adding to watchlist * fix owned safe count * restore page size, default shown, and max default shown * create PaginatedSafeList component for watchlist and owned safes * make isWatchlist non optional * type title as ReactNode and rename flag to isOnWatchlist * rename setMaxShownSafes everywhere * show watchlist safe count --------- Co-authored-by: katspaugh <[email protected]>
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Verified and can be included into RC. Let's check it together with Counterfactual safe feature |
@mike10ca , a new Side menu will break our sidebar menu regression cases - https://github.com/safe-global/safe-wallet-web/actions/runs/7960401233 |
Redesign the Safe List in the sidebar according to the new Login Page design (see #3233).
Displaying pending Txs and fiat balance will come in a separate PR