Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add more tests for address book #3241

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Feb 12, 2024

What it solves

Resolves #3229

How this PR fixes it

  • Added tests to cover remaining tests in Address Book

Tests added:

  • Verify an entry can be added by ENS name
  • Verify empty name is not allowed when editing
  • Verify clicking on Send button autofills the recipient filed with correct value
  • Verify Name and Address columns sorting works
  • Verify that edit owners name changes the name in the settings
  • Verify that editing an entry from the transaction details updates the name in address book
  • Verify copy to clipboard/Etherscan work as expected

How to test it

  • Run Cypress tests and observe outcome

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 12, 2024

Copy link

github-actions bot commented Feb 12, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/address-book 26.54 KB (🟡 +24 B) 1.05 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.57% (-0.34% 🔻)
11416/14530
🔴 Branches
56.12% (-0.7% 🔻)
2516/4483
🟡 Functions
63.15% (-0.48% 🔻)
1810/2866
🟡 Lines
79.87% (-0.34% 🔻)
10298/12893
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.ts
69.49%
55.56% (-8.08% 🔻)
43.75% 68.63%
🟢
... / useGasPrice.ts
92.31% (-3.08% 🔻)
75.76% (-6.06% 🔻)
90% (-10% 🔻)
93.55% (-1.61% 🔻)
🟢
... / index.tsx
96.15% (-0.07% 🔻)
71.43% (-1.9% 🔻)
76.92%
96% (-0.08% 🔻)
🔴
... / utils.ts
46.58% (-1.66% 🔻)
30.77% (-6.73% 🔻)
30%
46.27% (-1.73% 🔻)
🟢
... / useWalletBalance.ts
84.62%
66.67% (-33.33% 🔻)
100% 83.33%
🔴
... / relaying.ts
66.67% (-33.33% 🔻)
0% (-50% 🔻)
0% (-100% 🔻)
50% (-50% 🔻)
🟡
... / CounterfactualForm.tsx
72.73% (-0.8% 🔻)
33.33% (-13.33% 🔻)
50%
73.02% (-0.83% 🔻)
🟡
... / useDeployGasLimit.ts
78.26% (-21.74% 🔻)
11.11% (-77.78% 🔻)
66.67% (-33.33% 🔻)
76.19% (-23.81% 🔻)
🔴
... / index.tsx
46.88% (-35.6% 🔻)
12.5% (-40% 🔻)
9.09% (-63.64% 🔻)
48.89% (-34.63% 🔻)
🟢
... / index.tsx
80% (-20% 🔻)
100%
0% (-100% 🔻)
100%

Test suite run success

1389 tests passing in 188 suites.

Report generated by 🧪jest coverage report action from 4e2d402

@mike10ca mike10ca marked this pull request as ready for review February 12, 2024 20:21
@francovenica francovenica self-requested a review February 13, 2024 02:38
Copy link
Contributor

@francovenica francovenica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike10ca mike10ca merged commit 6e78cf8 into dev Feb 13, 2024
20 checks passed
@mike10ca mike10ca deleted the tess-address-book-rem-p2 branch February 13, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress tests to remaining address book tests
2 participants