[Counterfactual] Disable notifications and message signing #3240

usame-algan · 2024-02-12T16:57:31Z

What it solves

Part of #3156

How this PR fixes it

Disables the Notifications Banner for newly created counterfactual safes
Disables the Button on the Notifications settings page
Hides counterfactual safes from the Global notifications page
Disables the sign message flow for counterfactual safes

How to test it

Create a new counterfactual safe
Observe no Popup saying "Enable all"
Go to the Notification settings
Observe a disabled button
Go to the global notification preferences
Observe the safe is not showing up in the list
Connect your safe with an app to create an off-chain message (e.g. opensea)
Observe an error message in the modal and the Sign button is disabled

Screenshots

Checklist

I've tested the branch on mobile 📱
I've documented how it affects the analytics (if at all) 📊
I've written a unit/e2e test for it (if applicable) 🧑‍💻

github-actions · 2024-02-12T16:57:45Z

Branch preview

✅ Deploy successful!

https://cf_disable_notifications--walletweb.review-wallet-web.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

github-actions · 2024-02-12T16:58:33Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	1	0
Ignored	0	N/A

Result: ✅ success
Annotations: 1 total

[warning] react-hooks/exhaustive-deps

verifies the list of dependencies for Hooks like useEffect and similar

src/components/settings/PushNotifications/GlobalPushNotifications.tsx Line 287 - React Hook useMemo has a missing dependency: 'undeployedSafes'. Either include it or remove the dependency array.

^{Report generated by eslint-plus-action}

github-actions · 2024-02-12T17:01:16Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`1.02 MB` (🟡 +30 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/settings/notifications`	`12.49 KB` (🟡 +798 B)	1.04 MB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-02-12T17:04:43Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	78.89% (+0% 🔼)	11522/14606
🔴	Branches	56.88% (+0.05% 🔼)	2578/4532
🟡	Functions	63.65% (+0.04% 🔼)	1833/2880
🟢	Lines	80.2% (+0% 🔼)	10393/12959

Test suite run success

1400 tests passing in 190 suites.

Report generated by 🧪jest coverage report action from 6feb75a

github-actions · 2024-02-13T16:21:18Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2024-02-14T03:27:25Z

Looks good to me

Notifications pop up when creating a CF doesn't show up.
Notifications are locked for CF safes in the settings
The CF is not listed in the global settings for notifications
The error message is in the Message Form to sign (and the sign button is disabled)

Also checked that:
Enabling all notifications in all the safes in the network, then deployed the CF safe, then checking the global settings for notifications the CF safe is not checked (confirming that the enabling of notifcations was not affecting the CF safe)
The notification pop up still works for deployed safes (adding deployed safes, or paying for the creation of one)
Notifications can be enabled for a CF safe that was deployed.

compojoom · 2024-02-14T11:56:19Z

src/components/settings/PushNotifications/GlobalPushNotifications.tsx

@@ -37,6 +41,16 @@ import css from './styles.module.css'

 // UI logic

+const _filterUndeployedSafes = (safes: NotifiableSafes, undeployedSafes: UndeployedSafesState) => {


safes here is a {[chain]: [address1, address2]} but since the variable name is safes I thought it was a safe object and later when we do difference(safes, undeployedAddresses) I was astonished that it works :)
Maybe at least in mapValues we could call it safeAddresses?

compojoom · 2024-02-14T12:00:17Z

src/components/settings/PushNotifications/PushNotificationsBanner/index.tsx

@@ -121,7 +121,12 @@ export const PushNotificationsBanner = ({ children }: { children: ReactElement }
  const isSafeAdded = !!addedSafesOnChain?.[safeAddress]
  const isSafeRegistered = getPreferences(safe.chainId, safeAddress)
  const shouldShowBanner = useDebounce(


just curious - why do we have to debounce here?

I think the issue was that there were too many popups opening up at the same time which looked messy. This way there is a small delay before this popup opens. Not ideal but a bit better on the UX side.

compojoom · 2024-02-14T12:03:44Z

src/components/settings/PushNotifications/index.tsx

@@ -140,7 +140,7 @@ export const PushNotifications = (): ReactElement => {
                        <FormControlLabel
                          control={<Switch checked={!!preferences} onChange={handleOnChange} />}
                          label={preferences ? 'On' : 'Off'}
-                          disabled={!isOk || isRegistering}
+                          disabled={!isOk || isRegistering || !safe.deployed}


in SignMessage we do const isDisabled= which I prefer, but ok :)

Agree, with that many variables it makes sense to extract it into a new one for better readability.

One issue is that here we have the isOk variable which comes from the HoC so we can't extract that easily.

fix: Disable notifications for undeployed safes

cac607c

usame-algan requested a review from compojoom February 12, 2024 16:57

usame-algan changed the title ~~fix: Disable notifications for undeployed safes~~ [Counterfactual] Disable notifications for undeployed safes Feb 12, 2024

usame-algan requested a review from katspaugh February 13, 2024 12:06

usame-algan added 2 commits February 13, 2024 17:20

fix: extend dependency array

a4f0f0f

Merge remote-tracking branch 'origin/dev' into cf-disable-notifications

edd2366

fix: Disable sign message modal for undeployed safes

2ebc381

usame-algan changed the title ~~[Counterfactual] Disable notifications for undeployed safes~~ [Counterfactual] Disable notifications and message signing for undeployed safes Feb 13, 2024

usame-algan changed the title ~~[Counterfactual] Disable notifications and message signing for undeployed safes~~ [Counterfactual] Disable notifications and message signing Feb 13, 2024

compojoom reviewed Feb 14, 2024

View reviewed changes

compojoom approved these changes Feb 14, 2024

View reviewed changes

usame-algan added 2 commits February 14, 2024 13:12

refactor: Rename variables in filterUndeployedSafes

8d49cac

fix: Write tests for filterUndeployedSafes

6feb75a

usame-algan force-pushed the cf-disable-notifications branch from 38929ed to 6feb75a Compare February 14, 2024 12:35

usame-algan merged commit 558d48e into dev Feb 14, 2024
15 checks passed

usame-algan deleted the cf-disable-notifications branch February 14, 2024 12:53

github-actions bot locked and limited conversation to collaborators Feb 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Counterfactual] Disable notifications and message signing #3240

[Counterfactual] Disable notifications and message signing #3240

usame-algan commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading

francovenica commented Feb 14, 2024

compojoom Feb 14, 2024

compojoom Feb 14, 2024

usame-algan Feb 14, 2024

compojoom Feb 14, 2024

usame-algan Feb 14, 2024

usame-algan Feb 14, 2024

		@@ -37,6 +41,16 @@ import css from './styles.module.css'

		// UI logic

		const _filterUndeployedSafes = (safes: NotifiableSafes, undeployedSafes: UndeployedSafesState) => {

[Counterfactual] Disable notifications and message signing #3240

[Counterfactual] Disable notifications and message signing #3240

Conversation

usame-algan commented Feb 12, 2024 • edited Loading

What it solves

How this PR fixes it

How to test it

Screenshots

Checklist

github-actions bot commented Feb 12, 2024 • edited Loading

Branch preview

github-actions bot commented Feb 12, 2024

ESLint Summary View Full Report

[warning] react-hooks/exhaustive-deps

github-actions bot commented Feb 12, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

⚠️ Global Bundle Size Increased

One Page Changed Size

github-actions bot commented Feb 12, 2024 • edited Loading

Coverage report

Test suite run success

github-actions bot commented Feb 13, 2024 • edited Loading

ESLint Summary View Full Report

francovenica commented Feb 14, 2024

compojoom Feb 14, 2024

Choose a reason for hiding this comment

compojoom Feb 14, 2024

Choose a reason for hiding this comment

usame-algan Feb 14, 2024

Choose a reason for hiding this comment

compojoom Feb 14, 2024

Choose a reason for hiding this comment

usame-algan Feb 14, 2024

Choose a reason for hiding this comment

usame-algan Feb 14, 2024

Choose a reason for hiding this comment

usame-algan commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024 •

edited

Loading