Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safari] Sidebar CSS is broken fix #3235

Conversation

Moganesan
Copy link
Contributor

@Moganesan Moganesan commented Feb 11, 2024

What it solves

Resolves #3194

How this PR fixes it

the issue is coming from the MUI component i decided to remove the component and updated with the normal element now the issue is resolved and tested in the both chrome and safary.

How to test it

Screenshots

Screen.Recording.2024-02-11.at.1.00.35.PM.1.mp4

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@Moganesan Moganesan changed the title sidebar-open-safe-accounts-list drawer button updated [Safari] Sidebar CSS is broken fix Feb 11, 2024
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir!

@katspaugh katspaugh merged commit a315552 into safe-global:dev Feb 12, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safari] Sidebar CSS is broken
2 participants