Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Counterfactual] Display option to refresh balances #3227

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Feb 8, 2024

What it solves

Resolves #

How this PR fixes it

  • Adds a section to the assets page for counterfactual safes to refresh balance and a link to block explorer
  • The refresh button has a cooldown of 15s to mitigate potential spam

How to test it

  1. Create a counterfactual safe
  2. Open the assets page
  3. Observe a new section
  4. Disconnect your wallet
  5. Send ETH to your counterfactual safe
  6. Wait until the transaction has been executed
  7. Press "Refresh balance"
  8. The new balance should be visible within the next 15s

Screenshots

Screenshot 2024-02-08 at 21 20 47

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 8, 2024

Copy link

github-actions bot commented Feb 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 8, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟡 +13 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 28.09 KB (🟡 +406 B) 1.05 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 8, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.61% (+0.04% 🔼)
11455/14572
🔴 Branches
56.22% (+0.1% 🔼)
2530/4500
🟡 Functions
63.21% (+0.05% 🔼)
1816/2873
🟡 Lines
79.91% (+0.03% 🔼)
10331/12929
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / CheckBalance.tsx
84.21% 25% 50% 82.35%
🟢
... / index.tsx
100% 100% 100% 100%

Test suite run success

1392 tests passing in 189 suites.

Report generated by 🧪jest coverage report action from f64feda

Copy link

github-actions bot commented Feb 9, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francovenica
Copy link
Contributor

So the section is there, and the button has the 15 sec limit, but is hard to test since the assets, in my case update really fast, so you don't know if the button is doing its job or not.
I don't see calls in the network that I can block or something to make the button fail on purpose.

Is hard for me to say that the button works fine. I don't see any issues, but I'll ask Usame to look it together before merging it.

@usame-algan
Copy link
Member Author

Is hard for me to say that the button works fine. I don't see any issues, but I'll ask Usame to look it together before merging it.

I updated the PR description with steps on how to test this. This is easiest to test when there is no wallet connected. Let me know if it works for you.

@francovenica
Copy link
Contributor

Even disconnected is pretty fast, but I was able to see it.

Found an issue I didn't see before:
1 - Changing pages (like going to tx and back) re enables the button, allowing spamming it.

@usame-algan
Copy link
Member Author

Changing pages (like going to tx and back) re enables the button, allowing spamming it.

I think this is fine for now as reloading the page also enables the button again. We will add tracking to this button and in case it gets spammed we can take more measures.

@liliya-soroka
Copy link
Member

Is it expected? ( Just created counterfactual safe )
image

@usame-algan
Copy link
Member Author

Is it expected? ( Just created counterfactual safe )

Yes. This section should always be visible on the assets page for counterfactual safes

@liliya-soroka
Copy link
Member

Ok, verified

@usame-algan usame-algan merged commit 98553c8 into dev Feb 12, 2024
15 checks passed
@usame-algan usame-algan deleted the cf-balance-refresh branch February 12, 2024 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants