-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Counterfactual] Display option to refresh balances #3227
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.02 MB (🟡 +13 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/balances |
28.09 KB (🟡 +406 B) |
1.05 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1392 tests passing in 189 suites. Report generated by 🧪jest coverage report action from f64feda |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
So the section is there, and the button has the 15 sec limit, but is hard to test since the assets, in my case update really fast, so you don't know if the button is doing its job or not. Is hard for me to say that the button works fine. I don't see any issues, but I'll ask Usame to look it together before merging it. |
fddcad4
to
f64feda
Compare
I updated the PR description with steps on how to test this. This is easiest to test when there is no wallet connected. Let me know if it works for you. |
Even disconnected is pretty fast, but I was able to see it. Found an issue I didn't see before: |
I think this is fine for now as reloading the page also enables the button again. We will add tracking to this button and in case it gets spammed we can take more measures. |
Yes. This section should always be visible on the assets page for counterfactual safes |
Ok, verified |
What it solves
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist