Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ENS resolution #3219

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: ENS resolution #3219

merged 1 commit into from
Feb 7, 2024

Conversation

usame-algan
Copy link
Member

What it solves

The ENS resolution stopped working after #3208.

How this PR fixes it

This PR partially reverts the changes and instantiates the JsonRpcProvider without a network object.

How to test it

  1. Open a safe on mainnet or sepolia
  2. Create a new transaction
  3. Type an ENS as the recipient
  4. Observe the name resolves

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 7, 2024

Copy link

github-actions bot commented Feb 7, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 7, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.02 MB (-20 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Feb 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.88% 11259/14274
🔴 Branches 56.63% 2504/4422
🟡 Functions 63.2% 1795/2840
🟢 Lines 80.22% 10154/12658

Test suite run success

1383 tests passing in 186 suites.

Report generated by 🧪jest coverage report action from 3154217

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@usame-algan usame-algan merged commit 14d9412 into dev Feb 7, 2024
15 checks passed
@usame-algan usame-algan deleted the fix-ens-resolution branch February 7, 2024 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants