Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update WalletConnect packages #3216

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Chore: update WalletConnect packages #3216

merged 1 commit into from
Feb 7, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Update WalletConnect packages (see their release notes), plus add a yarn command to do it easier next time.

Copy link

github-actions bot commented Feb 7, 2024

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Feb 7, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 7, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.02 MB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Feb 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.88% 11259/14274
🔴 Branches 56.63% 2504/4422
🟡 Functions 63.2% 1795/2840
🟢 Lines 80.22% 10154/12658

Test suite run success

1383 tests passing in 186 suites.

Report generated by 🧪jest coverage report action from 5e361d2

@katspaugh
Copy link
Member Author

I'll merge directly since it's just a minor package update. I've tested that connecting a dapp and signing a tx still works.

@katspaugh katspaugh merged commit 18239b2 into dev Feb 7, 2024
12 of 15 checks passed
@katspaugh katspaugh deleted the update-wc branch February 7, 2024 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants