-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: enable Safe version 1.4.1 #3209
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1.02 MB (🟡 +62 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show files with reduced coverage 🔻
Test suite run success1399 tests passing in 190 suites. Report generated by 🧪jest coverage report action from dc8eb67 |
@@ -19,7 +19,7 @@ export const isLegacyVersion = (safeVersion: string): boolean => { | |||
} | |||
|
|||
export const isValidSafeVersion = (safeVersion?: SafeInfo['version']): safeVersion is SafeVersion => { | |||
const SAFE_VERSIONS: SafeVersion[] = ['1.3.0', '1.2.0', '1.1.1', '1.0.0'] | |||
const SAFE_VERSIONS: SafeVersion[] = ['1.4.1', '1.3.0', '1.2.0', '1.1.1', '1.0.0'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a config constant? Why don't we keep it in config/constants.ts next to the LATEST_SAFE_VERSION? Maybe changing it to:
export const LATEST_SAFE_VERSION = process.env.NEXT_PUBLIC_SAFE_VERSION || '1.3.0'
export SUPPORTED_SAFE_VERSION = ['1.4.1', '1.3.0', '1.2.0', '1.1.1', '1.0.0']
This way both const will live next to each other and supporting 1.5 one day would be just changing config/constants.ts file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this altogether because ultimately it just repeats the same check in the protocol-kit. We can instead look up the version via protocol-kit or safe-deployments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There is also the |
|
|
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Fixed by pulling from dev. |
Verified |
What it solves
Resolves #2558
Add 1.4.1 to the list of valid Safe versions.
How to test it