Release 1.29.0 #3206

schmanu · 2024-02-06T10:30:35Z

Features

Feat: enable base sepolia (Feat: enable base sepolia #3157)

Improvements

Fix: edit Safe Apps heading (Fix: edit Safe Apps heading #3193)
Refactor: remove QR scanner in address inputs (Refactor: remove QR scanner in address inputs #3165)
Refactor: remove custom ENS resolver for Sepolia (Refactor: remove custom ENS resolver for Sepolia #3204)
Fix: update the Safe Apps SDK link (Fix: update the Safe Apps SDK link #3213)
fix: ENS resolution (fix: ENS resolution #3219)
Fix: rm old domain link (Fix: rm old domain link #3221)

Tests & Chores

Tests: E2e fix create tx test (Test: E2e fix create tx test #3205)
Tests: add sidebar tests -p2 (Tests: add sidebar tests -p2 #3201)
Tests: E2e Assets - Adding the token test file (Tests: E2e Assets - Adding the token test file #3077)
Tests: Sidebar tests (Tests: Sidebar tests #3188)
Chore: update WalletConnect packages (Chore: update WalletConnect packages #3216)
tests: add sidebar tests -p3 (Tests: add sidebar tests -p3 #3211)

* tests: add sidebar tests

* remove balances file, add tokens file * remove 'only' from test * Send button disabled verification * solving clonflict with test safes * fix balances test * Change safe in token test * adding verifyOwner method * renaming method

* tests: add sidebar tests -p2 * tests: replace hardcoded currency value with element

- updates safe-deployments - updates safe-core-sdk packages

github-actions · 2024-02-06T10:30:52Z

Branch preview

✅ Deploy successful!

https://release--walletweb.review-wallet-web.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

github-actions · 2024-02-06T10:32:50Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-02-06T10:34:58Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page	Size (compressed)
`global`	`1.02 MB` (🟢 -122 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions · 2024-02-06T10:38:30Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	78.9% (+0.07% 🔼)	11262/14274
🔴	Branches	56.65% (+0.03% 🔼)	2505/4422
🟡	Functions	63.24% (+0.13% 🔼)	1796/2840
🟢	Lines	80.24% (+0.06% 🔼)	10157/12658

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / transactions.ts	94.29% (-2.77% 🔻)	100%	80% (-8.89% 🔻)	93.1% (-3.33% 🔻)
🟡	`...` / sdk.ts	69.05% (-0.72% 🔻)	35.29%	72.73%	68% (-0.83% 🔻)
🟢	`...` / index.tsx	100%	95% (-2.3% 🔻)	100%	100%
🟢	`...` / index.ts	100%	75% (-6.82% 🔻)	100%	100%

Test suite run success

1383 tests passing in 186 suites.

Report generated by 🧪jest coverage report action from e881ab1

liliya-soroka · 2024-02-06T12:07:58Z

Regression run is green - https://github.com/safe-global/safe-wallet-web/actions/runs/7799247520

- also fixes lint issues in test files

github-actions · 2024-02-07T17:00:09Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

francovenica · 2024-02-08T02:54:30Z

I've checked the latest addition of the ENS name fixing. looks good
The QR code icon was removed from address inputs

I've checked base sepolia, doing different types of txs with different safes and devices, different policies, I didn't find any issues.

From my side the release looks good to deploy

usame-algan

LGTM

liliya-soroka · 2024-02-08T09:28:41Z

https://github.com/safe-global/safe-wallet-web/actions/runs/7827359700 - all green

katspaugh and others added 7 commits February 1, 2024 12:10

Refactor: remove QR scanner in address inputs (#3165)

e55c145

Tests: Sidebar tests (#3188)

81713cb

* tests: add sidebar tests

Tests: E2e Assets - Adding the token test file (#3077)

16cd21a

* remove balances file, add tokens file * remove 'only' from test * Send button disabled verification * solving clonflict with test safes * fix balances test * Change safe in token test * adding verifyOwner method * renaming method

Tests: add sidebar tests -p2 (#3201)

4c98177

* tests: add sidebar tests -p2 * tests: replace hardcoded currency value with element

Fix: edit Safe Apps heading (#3193)

f220e81

Test: E2e fix create tx test (#3205)

b2e774b

Feat: enable base sepolia (#3157)

91f4418

- updates safe-deployments - updates safe-core-sdk packages

schmanu and others added 6 commits February 6, 2024 16:14

fix: do not forward eth_chainId (#3208)

7a0e42f

- also fixes lint issues in test files

Refactor: remove custom ENS resolver for Sepolia (#3204)

074146d

Fix: update the Safe Apps SDK link (#3213)

5908386

Chore: update WalletConnect packages (#3216)

18239b2

tests: add sidebar tests -p3 (#3211)

9887d96

fix: ENS resolution (#3219)

14d9412

usame-algan force-pushed the release branch from 60231bb to b469efb Compare February 7, 2024 16:58

usame-algan approved these changes Feb 8, 2024

View reviewed changes

katspaugh and others added 2 commits February 8, 2024 10:41

Fix: rm old domain link (#3221)

4a9006c

1.29.0

e881ab1

katspaugh force-pushed the release branch from 5ee0665 to e881ab1 Compare February 8, 2024 09:42

katspaugh merged commit e881ab1 into main Feb 8, 2024
15 checks passed

katspaugh deleted the release branch February 8, 2024 09:54

github-actions bot locked and limited conversation to collaborators Feb 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.29.0 #3206

Release 1.29.0 #3206

schmanu commented Feb 6, 2024 •

edited by katspaugh

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

liliya-soroka commented Feb 6, 2024

github-actions bot commented Feb 7, 2024 •

edited

Loading

francovenica commented Feb 8, 2024

usame-algan left a comment

liliya-soroka commented Feb 8, 2024

Release 1.29.0 #3206

Release 1.29.0 #3206

Conversation

schmanu commented Feb 6, 2024 • edited by katspaugh Loading

Features

Improvements

Tests & Chores

github-actions bot commented Feb 6, 2024 • edited Loading

Branch preview

github-actions bot commented Feb 6, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Feb 6, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

🎉 Global Bundle Size Decreased

github-actions bot commented Feb 6, 2024 • edited Loading

Coverage report

Test suite run success

liliya-soroka commented Feb 6, 2024

github-actions bot commented Feb 7, 2024 • edited Loading

ESLint Summary View Full Report

francovenica commented Feb 8, 2024

usame-algan left a comment

Choose a reason for hiding this comment

liliya-soroka commented Feb 8, 2024

schmanu commented Feb 6, 2024 •

edited by katspaugh

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 6, 2024 •

edited

Loading

github-actions bot commented Feb 7, 2024 •

edited

Loading