Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Counterfactual] Enable addOwner and swapOwner flow for counterfactual safes #3192

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #3191

How this PR fixes it

  • Implements addOwner and swapOwner functions for undeployed safes

How to test it

  1. Create a counterfactual 1/1 safe
  2. Navigate to the settings page
  3. Add or swap an owner
  4. Observe that there are no errors in the transaction flow
  5. Observe that the transaction executes, deploys the safe and adds/swaps the owner

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Feb 5, 2024

Copy link

github-actions bot commented Feb 5, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Feb 5, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.02 MB (-4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 64.15 KB (🟡 +129 B) 1.09 MB
/settings/setup 70.93 KB (🟡 +247 B) 1.09 MB
/transactions 92.64 KB (🟡 +129 B) 1.11 MB
/transactions/history 92.61 KB (🟡 +129 B) 1.11 MB
/transactions/messages 49.44 KB (🟡 +129 B) 1.07 MB
/transactions/queue 44.54 KB (🟡 +129 B) 1.07 MB
/transactions/tx 34.07 KB (🟡 +129 B) 1.06 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Feb 5, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.56% (-0.05% 🔻)
11409/14523
🔴 Branches
56.13% (-0.08% 🔻)
2515/4481
🟡 Functions
63.15% (-0.02% 🔻)
1810/2866
🟡 Lines
79.86% (-0.05% 🔻)
10291/12886
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / create.ts
48.44% (-6.46% 🔻)
60% (-40% 🔻)
23.08%
50.98% (-6.52% 🔻)
🟡
... / useDeployGasLimit.ts
78.26% (-4.09% 🔻)
11.11% (-8.89% 🔻)
66.67% (-33.33% 🔻)
76.19% (-3.81% 🔻)

Test suite run success

1389 tests passing in 188 suites.

Report generated by 🧪jest coverage report action from f48a4cd

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK as a first stab at it but we need to come up with a more elegant way of doing it once and for all tx types.

@usame-algan usame-algan changed the title fix: Enable addOwner and swapOwner flow for counterfactual safes [Counterfactual] Enable addOwner and swapOwner flow for counterfactual safes Feb 5, 2024
@francovenica
Copy link
Contributor

Tried both add an owner or swapping, but I always get the same error when trying to execute the tx:

image

@usame-algan
Copy link
Member Author

Tried both add an owner or swapping, but I always get the same error when trying to execute the tx:

Thanks for testing! Seems to be an issue with the estimated gas being too low. I will look into it.

Copy link

github-actions bot commented Feb 6, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan force-pushed the cf-first-tx branch 2 times, most recently from d8bbf98 to 8a26207 Compare February 6, 2024 20:15
Base automatically changed from cf-first-tx to dev February 8, 2024 11:11
Copy link

github-actions bot commented Feb 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

@francovenica I've added fixed gas (25k) on top of the estimation for swap owner and add owner transactions. That should work now although not an ideal solution.

@francovenica
Copy link
Contributor

LGTM now, the issue I reported was fixed.

Adding/replacing an owner works fine now, and deploys the safe just fine as well

@usame-algan usame-algan merged commit 88c5b56 into dev Feb 9, 2024
15 checks passed
@usame-algan usame-algan deleted the cf-owner-tx branch February 9, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Counterfactual] Add support for safe settings transactions
3 participants