-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Counterfactual] Enable addOwner and swapOwner flow for counterfactual safes #3192
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1389 tests passing in 188 suites. Report generated by 🧪jest coverage report action from f48a4cd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK as a first stab at it but we need to come up with a more elegant way of doing it once and for all tx types.
d2b8ba3
to
d10c7aa
Compare
Thanks for testing! Seems to be an issue with the estimated gas being too low. I will look into it. |
d65fa53
to
a58fea0
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
d8bbf98
to
8a26207
Compare
a58fea0
to
dfeef8c
Compare
ESLint Summary View Full Report
Report generated by eslint-plus-action |
@francovenica I've added fixed gas (25k) on top of the estimation for swap owner and add owner transactions. That should work now although not an ideal solution. |
LGTM now, the issue I reported was fixed. Adding/replacing an owner works fine now, and deploys the safe just fine as well |
What it solves
Resolves #3191
How this PR fixes it
addOwner
andswapOwner
functions for undeployed safesHow to test it
Screenshots
Checklist