Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove experimental address emoji #2834

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix: remove experimental address emoji #2834

merged 1 commit into from
Nov 24, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Removing the emoji Safe avatars due to very low usage and no overwhelmingly positive feedback. Originally introduced in #2305.

Stats from Sep 1 to Nov 20:
Screenshot 2023-11-21 at 10 43 40

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 21, 2023

Branch preview

✅ Deploy successful!

https://rm_emoji--walletweb.review-wallet-web.5afe.dev

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.39 MB (🟢 -558 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/appearance 8.19 KB (🟢 -349 B) 1.4 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.91% (-0.01% 🔻)
9955/13114
🔴 Branches
50.19% (+0.03% 🔼)
2027/4039
🔴 Functions
58.76% (+0.04% 🔼)
1492/2539
🟡 Lines
77.48% (-0.02% 🔻)
8993/11607
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
94.44% (-0.29% 🔻)
95.24% (-0.22% 🔻)
50% 100%
🟢
... / index.tsx
83.33% (-2.38% 🔻)
0% 0%
80% (-3.33% 🔻)

Test suite run success

1093 tests passing in 153 suites.

Report generated by 🧪jest coverage report action from b03a51d

@katspaugh katspaugh modified the milestones: 1.3.0, 1.23.0 Nov 21, 2023
@francovenica
Copy link
Contributor

Looks good. The setting is gone

kinda sad about this one, not gonna lie

@katspaugh katspaugh merged commit 51d1962 into dev Nov 24, 2023
15 checks passed
@katspaugh katspaugh deleted the rm-emoji branch November 24, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants