Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Cypress seedless google flow #2812

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves #2811

How this PR fixes it

  • Add seedless tests Google happy path flow

Copy link

github-actions bot commented Nov 15, 2023

Branch preview

✅ Deploy successful!

https://cypress_seedless_google_flow--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 15, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 15, 2023

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1.4 MB (🟡 +47 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 26.72 KB (🟡 +24 B) 1.42 MB
/new-safe/create 11.83 KB (🟡 +68 B) 1.41 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 15, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.04% (-0.08% 🔻)
10107/13469
🔴 Branches
49.57% (-0.11% 🔻)
2054/4144
🔴 Functions
57.54% (-0.09% 🔻)
1500/2607
🟡 Lines
76.6% (-0.09% 🔻)
9142/11934
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / SocialLoginModule.ts
58.46% (-2.41% 🔻)
30%
62.5% (-7.5% 🔻)
57.89%
🟢
... / useMPC.ts
91.67% (-1.19% 🔻)
92.31% (-7.69% 🔻)
71.43%
93.02% (-1.42% 🔻)
🔴
... / useSocialWallet.ts
45.45% (-7.88% 🔻)
0% (-100% 🔻)
0%
41.03% (-18.97% 🔻)
🔴
... / PasswordRecoveryModal.tsx
32.14% (-3.57% 🔻)
0% 0% 40.91%

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 9ee5192

@mike10ca mike10ca marked this pull request as ready for review November 15, 2023 10:59
Copy link
Contributor

@francovenica francovenica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike10ca mike10ca merged commit 3598c18 into dev Nov 15, 2023
14 checks passed
@mike10ca mike10ca deleted the cypress-seedless-google-flow branch November 15, 2023 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add seedless Google happy path tests
2 participants