Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add test IDs and modify NFT tests #2804

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves
Part of #2776

How this PR fixes it

  • Add test IDs to nft component
  • Improve nft tests for reliability

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://cypress_test_improvemenets_nft--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 13, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 13, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.05% (+0.01% 🔼)
10104/13463
🔴 Branches 49.57% 2054/4144
🔴 Functions
57.56% (+0.02% 🔼)
1500/2606
🟡 Lines
76.61% (+0.01% 🔼)
9139/11929
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
84.72% (-11.43% 🔻)
58.82% (-12.61% 🔻)
66.67% (-10.26% 🔻)
85.51% (-10.49% 🔻)

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from b6c9434

@mike10ca mike10ca marked this pull request as ready for review November 14, 2023 09:02
@mike10ca mike10ca merged commit b356d75 into dev Nov 14, 2023
11 checks passed
@mike10ca mike10ca deleted the cypress-test-improvemenets-nft branch November 14, 2023 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants