Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow execution of web assembly #2797

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix: allow execution of web assembly #2797

merged 2 commits into from
Nov 13, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Nov 13, 2023

What it solves

Signing txs with a social signer is blocked by out CSPs

How this PR fixes it

Allows web assembly through the CSP directive 'wasm-unsafe-eval'

How to test it

Set IS_PRODUCTION to true locally and check the social login

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 13, 2023

Branch preview

✅ Deploy successful!

https://fix_web_assembly--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 13, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 13, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.04% (+0.02% 🔼)
10109/13472
🔴 Branches
49.54% (+0.02% 🔼)
2055/4148
🔴 Functions
57.46% (+0.04% 🔼)
1498/2607
🟡 Lines
76.61% (+0.02% 🔼)
9145/11937

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 0a5dbdd

@katspaugh katspaugh merged commit 8419d23 into dev Nov 13, 2023
7 of 13 checks passed
@katspaugh katspaugh deleted the fix-web-assembly branch November 13, 2023 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants