Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hydration error on the NFTs page #2788

Merged
merged 6 commits into from
Nov 12, 2023
Merged

fix: Hydration error on the NFTs page #2788

merged 6 commits into from
Nov 12, 2023

Conversation

usame-algan
Copy link
Member

What it solves

  • Resolves hydration error on the NFT Table when there is no linkTemplate (like on Sepolia)
  • Navigates directly to the NFT page in the e2e test
  • Resets balances to default token list for balances e2e test

How to test it

  1. Open the NFT page of a safe with NFTs on Sepolia
  2. Observe no hydration error

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_hydration_error--walletweb.review-wallet-web.5afe.dev

@usame-algan usame-algan changed the title fix: Hydration error on the NFTs page, adjust NFT e2e test accordingly fix: Hydration error on the NFTs page Nov 10, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
75.06% (+0.02% 🔼)
 10105/13463
🔴 Branches
49.59% (+0.02% 🔼)
 2055/4144
🔴 Functions
57.48% (+0.04% 🔼)
 1498/2606
🟡 Lines
76.63% (+0.02% 🔼)
 9141/11929

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 02d20e0

katspaugh
katspaugh approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

katspaugh
katspaugh reviewed Nov 11, 2023
View reviewed changes
public/worker-4f62d7a92535e0d2.js.LICENSE.txt Outdated
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this got added accidentally

@usame-algan usame-algan merged commit dc9d022 into dev Nov 12, 2023
11 checks passed
@usame-algan usame-algan deleted the fix-hydration-error branch November 12, 2023 23:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usame-algan @katspaugh