Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: redirect to Safe creation only if no added Safes #2781

Closed
wants to merge 2 commits into from

Conversation

katspaugh
Copy link
Member

An alternative to #2780.

Case 1:

  • User comes to the app for the first time
  • Connects a wallet or signs up via w3a
  • They are redirected straight to Safe creation

Case 2:

  • A returning user with added Safes comes to the app
  • Connects a wallet/w3a
  • Safe List opens

Copy link

github-actions bot commented Nov 9, 2023

Branch preview

❌ Deploy failed!

Copy link

github-actions bot commented Nov 9, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 9, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.1% (+0.05% 🔼)
10093/13440
🔴 Branches
49.59% (+0.04% 🔼)
2051/4136
🔴 Functions
57.64% (+0.08% 🔼)
1501/2604
🟡 Lines
76.65% (+0.03% 🔼)
9127/11908
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useWalletConnectSearchParamUri.ts
100% (+7.14% 🔼)
90% (-10% 🔻)
100% 100%
🔴
... / index.tsx
58.23%
14.63% (-0.37% 🔻)
27.27% 58.11%

Test suite run success

1105 tests passing in 155 suites.

Report generated by 🧪jest coverage report action from 779a1e0

@katspaugh katspaugh closed this Nov 9, 2023
@katspaugh katspaugh deleted the fix-redirect branch November 9, 2023 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant