Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove WC onboarding tooltip #2746

Merged
merged 6 commits into from
Nov 9, 2023
Merged

fix: Remove WC onboarding tooltip #2746

merged 6 commits into from
Nov 9, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 6, 2023

What it solves

As discussed on Slack we are removing the WC Onboarding tooltip.

How this PR fixes it

Removes the WC Onboarding Tooltip

Also fixes the Onboard Safe logo size on mobile

How to test it

  1. Open a Safe
  2. Observe no WC tooltip in the header

Screenshots

Screenshot 2023-11-06 at 16 39 28

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 6, 2023

Branch preview

✅ Deploy successful!

https://remove_wc_tooltip--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.18% 9462/12586
🔴 Branches 49.48% 1935/3911
🔴 Functions 57.92% 1423/2457
🟡 Lines 76.85% 8567/11147

Test suite run success

1046 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 778af60

katspaugh
katspaugh previously approved these changes Nov 6, 2023
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@francovenica
Copy link
Contributor

Looks good.

The tooltip is gone
The logo was fixed in mobile

katspaugh
katspaugh previously approved these changes Nov 7, 2023
@francovenica
Copy link
Contributor

Did something functional changed? or is just the e2e test? if it is just the test you can put it in QA done again

katspaugh
katspaugh previously approved these changes Nov 8, 2023
@usame-algan usame-algan merged commit e72f222 into dev Nov 9, 2023
13 checks passed
@usame-algan usame-algan deleted the remove-wc-tooltip branch November 9, 2023 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants