Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust connection center design #2745

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

usame-algan
Copy link
Member

What it solves

Part of #2452

How this PR fixes it

  • Updates the ConnectionCenter design
  • Uses the new Keyhole icon
  • Increases the spacing between elements

How to test it

  1. Open the safe
  2. Check the Not connected button in the header against Figma
  3. Check the Popover against Figma

Screenshots

Screenshot 2023-11-06 at 14 29 45 Screenshot 2023-11-06 at 14 29 52

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 6, 2023

Branch preview

✅ Deploy successful!

https://account_center_design--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

github-actions bot commented Nov 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.09% (+0% 🔼)
10061/13398
🔴 Branches
49.66% (-0.01% 🔻)
2053/4134
🔴 Functions
57.63% (+0.04% 🔼)
1496/2596
🟡 Lines
76.64% (-0% 🔻)
9100/11874
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / index.tsx
49.35%
13.33% (-3.33% 🔻)
9.09% 52.11%

Test suite run success

1102 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from 707a103

height: size,
width: size,
'& path': {
fill: ({ palette }) => palette.border.main,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also set fill=currentColor in the SVG and use the color CSS property.

@usame-algan usame-algan merged commit 232674c into web3authcoresdk Nov 6, 2023
11 checks passed
@usame-algan usame-algan deleted the account-center-design branch November 6, 2023 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants