Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add social login option to onboard module #2744

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 6, 2023

What it solves

Part of #2452

How this PR fixes it

  • Implements the eth_requestAccounts for the onboard module

How to test it

  1. Open the app
  2. Press Connect wallet
  3. Select Social Login
  4. Observe getting logged in
  5. Set a password
  6. Log out and login again
  7. Observe the password recovery modal opens
  8. Submit the modal
  9. Observe being logged in

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 6, 2023

Branch preview

✅ Deploy successful!

https://social_login_onboard--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 6, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.09% (-0.07% 🔻)
10065/13404
🔴 Branches
49.67% (-0.01% 🔻)
2054/4135
🔴 Functions
57.58% (-0.07% 🔻)
1496/2598
🟡 Lines
76.64% (-0.06% 🔻)
9104/11879
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / PasswordRecoveryModal.tsx
32.14% 0% 0% 40.91%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / SocialLoginModule.ts
59.02% (-13.08% 🔻)
33.33% (-16.67% 🔻)
66.67% (-10.26% 🔻)
56.36% (-12.06% 🔻)

Test suite run success

1102 tests passing in 154 suites.

Report generated by 🧪jest coverage report action from c9f16a4

@usame-algan usame-algan merged commit 010faca into web3authcoresdk Nov 6, 2023
9 of 11 checks passed
@usame-algan usame-algan deleted the social-login-onboard branch November 6, 2023 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants