Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: WalletConnect - track only tx and signature requests #2732

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Nov 2, 2023

What it solves

WalletConnect RPC request tracking was added in #2717.
This PR limits the types of requests being tracked to only transaction and signature requests. Otherwise we would track all kinds of "read-only" requests like eth_getChainid etc.

Also, track errors only once when they are thrown, not every time they're shown.

Copy link

github-actions bot commented Nov 2, 2023

Branch preview

⏳ Deploying a preview site...

Copy link

github-actions bot commented Nov 2, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 2, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.18% (-0% 🔻)
9462/12586
🔴 Branches
49.48% (-0.01% 🔻)
1935/3911
🔴 Functions
57.92% (+0.02% 🔼)
1423/2457
🟡 Lines
76.85% (+0% 🔼)
8567/11147
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / tracking.ts
85.71% 0% 100% 83.33%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / walletconnect.ts
75% (-25% 🔻)
100% 100% 100%

Test suite run success

1046 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from e3710c2

@liliya-soroka
Copy link
Member

Confirmed:

This PR limits the types of requests being tracked to only transaction and signature requests. Otherwise we would track all kinds of "read-only" requests like eth_getChainid etc. - "WC request" appears only on tx triggering from the connect dapp on web UI

Also, track errors only once when they are thrown, not every time they're shown. - confirmed

@katspaugh katspaugh merged commit 054b53b into dev Nov 2, 2023
3 of 7 checks passed
@katspaugh katspaugh deleted the wc-requests branch November 2, 2023 10:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants