Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: render mobile pairing correctly #2718

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Fix: render mobile pairing correctly #2718

merged 2 commits into from
Nov 1, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2711

How this PR fixes it

The mobile pairing modal was rendered in a completely separate React root which caused a lot of issues.

Copy link

github-actions bot commented Oct 31, 2023

Branch preview

✅ Deploy successful!

https://fix_pairing--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Oct 31, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Oct 31, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.16% (-0.11% 🔻)
9448/12571
🔴 Branches
49.38% (-0.09% 🔻)
1925/3898
🔴 Functions
57.88% (-0.31% 🔻)
1421/2455
🟡 Lines
76.83% (-0.07% 🔻)
8555/11135
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / QRModal.tsx
46.15% 0% 0% 57.14%
🔴
... / PairingQRCode.tsx
43.48% 0% 0% 45.45%
🟢
... / index.tsx
75% 0% 0% 85.71%
🟢
... / PairingDescription.tsx
85.71% 100% 0% 100%
🟡
... / index.tsx
60% 50% 33.33% 66.67%
🟢
... / PairingDeprecationWarning.tsx
75% 100% 0% 100%

Test suite run success

1044 tests passing in 142 suites.

Report generated by 🧪jest coverage report action from bdb29b6

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit 391bc56 into dev Nov 1, 2023
8 of 9 checks passed
@katspaugh katspaugh deleted the fix-pairing branch November 1, 2023 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile pairing] Modal window with QR code and deprecation message doesn't appear
3 participants