Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless Onboarding] Add alternative welcome page #2704

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 30, 2023

What it solves

Part of #2452

How this PR fixes it

  • Adds a new page /welcome-lp according to Figma
  • Changes the Safe List button from an accordion element to a button element
  • Extracts the Safe List Drawer and button so it can be reused

How to test it

  1. Open /welcome-lp and observe the page

Screenshots

Screenshot 2023-10-30 at 16 45 34 Screenshot 2023-10-30 at 16 54 26 Screenshot 2023-10-30 at 16 54 48

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Branch preview

✅ Deploy successful!

https://welcome_lp--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.83% (-0.38% 🔻)
9532/12738
🔴 Branches
48.64% (-0.98% 🔻)
1899/3904
🔴 Functions
57.29% (-0.57% 🔻)
1415/2470
🟡 Lines
76.39% (-0.34% 🔻)
8616/11279
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / bookmarked.tsx
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
94.12% (-1.72% 🔻)
0% (-80% 🔻)
100%
93.75% (-1.7% 🔻)
🟢 src/store/index.ts
98% (-0.04% 🔻)
100% 100% 100%
🟢 src/store/common.ts
88.89% (-11.11% 🔻)
0% (-50% 🔻)
66.67% (-33.33% 🔻)
85.71% (-14.29% 🔻)
🟢
... / formatters.ts
80.77% (-1.92% 🔻)
63.64% 83.33% 81.58%
🟢
... / addedSafesSlice.ts
83.33% (-5% 🔻)
71.43%
80% (-6.67% 🔻)
82.35% (-5.88% 🔻)
🟢
... / TagManager.ts
96.88% (-0.27% 🔻)
100%
88.89% (-1.11% 🔻)
96.55% (-0.32% 🔻)
🟢
... / addressBook.ts
66.67% (-33.33% 🔻)
100% 100% 100%
🟢
... / createLoadSafe.ts
66.67% (-33.33% 🔻)
100% 100% 100%
🟢
... / mobileAppPromotion.ts
66.67% (-33.33% 🔻)
100% 100% 100%
🟢
... / modals.ts
80% (-20% 🔻)
100% 100% 100%
🟢
... / safeApps.ts
70% (-30% 🔻)
100% 100% 100%
🟢
... / txList.ts
66.67% (-33.33% 🔻)
100% 100% 100%
🟢
... / batching.ts
75% (-25% 🔻)
100% 100% 100%
🟡
... / transactions.ts
60.18% (-0.35% 🔻)
31.03% (+2% 🔼)
28.57% 64.29%
🟡
... / safe-messages.ts
78.95%
61.11% (-3.89% 🔻)
100% 76.92%
🟢
... / useHighlightHiddenTab.ts
77.78% (+1.31% 🔼)
37.5% (-2.5% 🔻)
71.43% (-6.35% 🔻)
80% (+1.88% 🔼)
🟢
... / index.tsx
83.33% (-16.67% 🔻)
100% 0% 100%
🟢
... / index.tsx
69.23% (-7.69% 🔻)
0% 0% 81.82%
🟢
... / index.tsx
83.33% (-16.67% 🔻)
100% 0% 100%
🟢
... / index.tsx
100%
80% (-5.71% 🔻)
100% 100%
🔴
... / index.tsx
58.23%
15% (-0.79% 🔻)
27.27% 58.11%
🟡
... / index.tsx
62.5% (-1.79% 🔻)
0% 0%
65.79% (-1.71% 🔻)

Test suite run success

1005 tests passing in 144 suites.

Report generated by 🧪jest coverage report action from 77e7d6b

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -1,6 +1,7 @@
export const AppRoutes = {
'404': '/404',
welcome: '/welcome',
welcomeLp: '/welcome-lp',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/welcome/social-login perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require us to move the welcome page into a directory and rename all occurences of AppRoutes.welcome to AppRoutes.welcome.index though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware.

@usame-algan usame-algan merged commit 95ba442 into web3authcoresdk Oct 31, 2023
5 of 7 checks passed
@usame-algan usame-algan deleted the welcome-lp branch October 31, 2023 14:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants