Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable network selector if social login wallet not supported #2684

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 23, 2023

What it solves

Part of #2452

How this PR fixes it

  • Enables the network selector but disables its items where social login is not supported instead
  • Shows a tooltip in that case
  • For non social login wallets everything stays the same

How to test it

  1. Open Safe
  2. Open the network selector
  3. Observe all items are enabled
  4. Observe no Tooltip showing
  5. Connect with MM
  6. Step 2 and 3 are the same
  7. Connect with Google
  8. Observe the network selector is not disabled
  9. Observe some items inside the network selector are disabled
  10. Observe a tooltip

Screenshots

Screenshot 2023-10-23 at 18 01 19

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Branch preview

✅ Deploy successful!

https://disabled_networks--walletweb.review-wallet-web.5afe.dev

@usame-algan
Copy link
Member Author

@kirkkonen @TanyaEfremova Is this wording and design ok from your side?

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.63% 9462/12678
🔴 Branches 48.75% 1897/3891
🔴 Functions 56.52% 1382/2445
🟡 Lines 76.15% 8552/11230

Test suite run success

1007 tests passing in 143 suites.

Report generated by 🧪jest coverage report action from 8f07c04

@usame-algan usame-algan merged commit 0f2ba8b into web3authcoresdk Oct 25, 2023
6 of 8 checks passed
@usame-algan usame-algan deleted the disabled-networks branch October 25, 2023 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants