Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement design review feedback, restructure components #2683

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Oct 23, 2023

What it solves

Resolves #2452

How this PR fixes it

  • Renames account to social login signer on the settings page
  • Removes the word recovery on the settings page
  • Show "Passwords don't match" by default
  • Keep Password form closed by default
  • Show Chevron icon in the accordion

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Branch preview

✅ Deploy successful!

https://design_review--walletweb.review-wallet-web.5afe.dev

@usame-algan usame-algan changed the title fix: Address design review, restructure components fix: Implement design review feedback, restructure components Oct 23, 2023
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.42% (-0% 🔻)
9364/12583
🔴 Branches
48.55% (-0.03% 🔻)
1876/3864
🔴 Functions 56.29% 1370/2434
🟡 Lines
75.96% (-0% 🔻)
8467/11147
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / PasswordInput.tsx
50% 0% 0% 62.5%
🟡
... / index.tsx
57.41% 27.27% 37.5% 60%
🔴
... / helper.ts
28.13% 0% 0% 31.03%

Test suite run success

998 tests passing in 141 suites.

Report generated by 🧪jest coverage report action from 0cc6eff

@usame-algan usame-algan merged commit 5d05596 into web3authcoresdk Oct 23, 2023
7 of 8 checks passed
@usame-algan usame-algan deleted the design-review branch October 23, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants