fix: don't reject when signing #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Test suite run success1043 tests passing in 141 suites. Report generated by 🧪jest coverage report action from 30890fb |
katspaugh
reviewed
Oct 20, 2023
src/components/tx-flow/index.tsx
Outdated
| return newTxFlow | ||
| }) | ||
| (newTxFlow: TxModalContextType['txFlow'], onClose?: () => void, newShouldWarn?: boolean) => { | ||
| // If flow is open user opens a different one, show confirmation dialog if required |
katspaugh
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves successful signing requests rejecting in dApps
How this PR fixes it
The
USER_QUITevent is nly dispatched to the dApp if a warning requirement was set and is accepted when closing the flow, ergo not when a signature request succeeds and closes the flow.How to test it
Observe successful swaps on Aave, CoWSwap, Curve and Sushi (on 1/n Safes).
Checklist