Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error from blocking WC popup #2663

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: prevent error from blocking WC popup #2663

merged 1 commit into from
Oct 19, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves WC error never clearing

How this PR fixes it

All WC-related errors are closed after viewing them, as well as being truncated if they are too long.

How to test it

Connect to a dApp in one tab, then in another open the Safe on a chain that the connected-to dApp doesn't support. Refresh the former and observe an error present in the popup, truncated. When closing the popup, it should clear.

Screenshots

image

blocking-error

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 19, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Branch preview

✅ Deploy successful!

https://wc_blocking_error--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.31% (+0.02% 🔼)
9338/12399
🔴 Branches
49.6% (+0.03% 🔼)
1909/3849
🔴 Functions
57.82% (+0.02% 🔼)
1394/2411
🟡 Lines
76.92% (+0.02% 🔼)
8447/10981
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / WalletConnectContext.tsx
100% 100%
88.89% (-11.11% 🔻)
100%

Test suite run success

1043 tests passing in 141 suites.

Report generated by 🧪jest coverage report action from 45807ef

@iamacook iamacook merged commit 47215d8 into nect Oct 19, 2023
8 of 9 checks passed
@iamacook iamacook deleted the wc-blocking-error branch October 19, 2023 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants