fix: emit chainChanged first
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://wc_chain_alignment--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1026 tests passing in 141 suites. Report generated by 🧪jest coverage report action from c47e37a |
katspaugh
approved these changes
Oct 19, 2023
katspaugh
reviewed
Oct 19, 2023
| @@ -344,36 +344,36 @@ describe('WalletConnectWallet', () => { | |||
| expect(emitSessionEventSpy).toHaveBeenCalledTimes(2) | |||
| }) | |||
|
|
|||
| it('should call emitSessionEvent with the correct parameters', async () => { | |||
| it.only('should call emitSessionEvent with the correct parameters', async () => { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves dApp chain alignment
How this PR fixes it
The
chainChangedevent is not emitted before the `accountsChanged event when updating a session.How to test it
Connect to Aura Finance and observe the initial chain matching that of the Safe, as well as changing with Safe switches across chains.
Checklist